NEW Scaffolded field labels now only have an uppercased first word #8698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uh oh, I broke things! |
kinglozzer
approved these changes
Jan 7, 2019
robbieaverill
force-pushed
the
pulls/4.4/single-uppercase-label
branch
from
7dfb1f5
to
394dd47
Compare
|
Ok I've updated the tests that had labels like "My Field Name" in them to "My field name", fixed a couple of assertion argument orders and added handling for field names like |
|
I think that Scrutinizer failure is unrelated |
9 tasks
kinglozzer
approved these changes
Jan 8, 2019
This was referenced Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the unit test for examples of how this now behaves.
Resolves #8696