Restricted HTML comments and preview feature #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sweet, good enhancement. Will give it a whirl tonight to test it out but looks all fine from my end. Might just do some better default styling for the module to make it tidier out of the box (but that's another issue!) |
wilr
added a commit
that referenced
this pull request
Mar 5, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developed for a client. The preview feature is agnostic of any serverside parsing, so can also be used if we decide to implement shortcodes or markdown processing in comments.
I've checked how the preview renders in the default "simple" theme, and its not really any better or worse than the default comment formatting :) I've ensured the preview button is styled as a secondary action there, which is the most important bit (silverstripe/silverstripe-simple@c991a8e)