Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Remove TODO Comments #128

Merged

Conversation

sabina-talipova
Copy link
Contributor

@@ -39,7 +39,6 @@ Feature: Manage banner blocks
Given I click on block 1
And I fill in "Additional Banner Block" for "Title" for block 1
And I fill in "<p>Additional sample content</p>" for "Content" for block 1
# TODO Test adding files to a banner block via inline editing
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open ticket: #127

@GuySartorelli GuySartorelli changed the base branch from 3.1 to 3 May 28, 2024 23:12
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was missed at the time - LGTM

@GuySartorelli GuySartorelli merged commit 4c8f47b into silverstripe:3 May 28, 2024
12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/3.1/remove-todo branch May 28, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants