-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ElementalSolrIndex leads to double indexing #709
Comments
Yeah, we can deprecate it and write another one though. The solution was sub-optimal from the start, and we still haven't spent the time to implement a scalable search solution for the CMS either =/ |
But what would that new index to replace the deprecated one do? Some people will have started relying on it, assuming it'll actually index pages and blocks. |
Merged
chillu
added a commit
to open-sausages/silverstripe-elemental
that referenced
this issue
Aug 2, 2019
chillu
added a commit
to open-sausages/silverstripe-elemental
that referenced
this issue
Aug 2, 2019
chillu
added a commit
to open-sausages/silverstripe-elemental
that referenced
this issue
Aug 2, 2019
Marks master as 5.x, since this is the first API change. silverstripe#709
chillu
added a commit
to open-sausages/bambusa-installer
that referenced
this issue
Aug 4, 2019
Avoid double indexing, see silverstripe/silverstripe-elemental#709
robbieaverill
pushed a commit
to open-sausages/silverstripe-elemental
that referenced
this issue
Aug 4, 2019
Marks master as 5.x, since this is the first API change. silverstripe#709
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3a9b68e#diff-f4f232f03fb2b2386febaa611c6caef9
I'd say in 99% of the cases, this index won't cut it, and devs will create their own one anyway. Or extending the CWPSearchIndex.
The elemental index should be a how-to, not something you're force fed by default. From what I can tell, this has lead to double indexing of content since we introduced this back in 2017. So double the indexing time, double the index size. This has a significant impact on the usefulness of our overall search solution.
Given this is now part of our semver commitment, we can't really remove it without a major release (which won't benefit most of the target audience, namely CWP).
The cwp docs actually mention how you can create a filter whitelist. In lieu of actually fixing the underlying issue, I think the best we can do is to remind people upgrading that they should create such a whitelist.
The text was updated successfully, but these errors were encountered: