Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Changes flush and build URLs for tutorials.
- Loading branch information
1 parent
1b1f645
commit 29c2fec
Showing
5 changed files
with
15 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29c2fec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, why?
29c2fec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In most places ?flush=all is overkill, now that includes have the same filemtime() check, so slows things down for no real reason. When used in dev/build, it gave the false impression that templates would be flushed as well (no SSViewer, so they're not).
Then search tutorial had a link to home?flush=all for enabling search where it needs to be dev/build to get the table type changed to MyISM and the indexes added.
29c2fec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It was really just the change from flush=all to flush=1 that I was questioning. In the past using flush=1 could have tripped up new users, as they would assume it had flushed all templates, rather than just the one they were on. Does the filemtime() check fix that?
29c2fec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could easily have changed with the new include system in 3, but the mtime check used to not work when includes had changed.
29c2fec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It didn't work in 2.4 because includes were copied directly into the main template, so the check only happened on the main template. Now that they're rendered individually again, it works. I've certainly had a lot fewer "gah, forgot to flush" moments when working in includes, since now they're all manifest related too.