FIX Use content generated by DataColumns component for print and csv …

…export
silverstripe · Aug 9, 2019 · 3d989a6 · 3d989a6
1 parent 6f19cb3
commit 3d989a6
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/src/Forms/GridField/GridFieldExportButton.php b/src/Forms/GridField/GridFieldExportButton.php
@@ -214,6 +214,9 @@ public function generateExportFileData($gridField)
             }
         }
 
+        /** @var GridFieldDataColumns|null $gridFieldColumnsComponent */
+        $gridFieldColumnsComponent = $gridField->getConfig()->getComponentByType(GridFieldDataColumns::class);
+
         /** @var DataObject $item */
         foreach ($items->limit(null) as $item) {
             if (!$item->hasMethod('canView') || $item->canView()) {
@@ -228,6 +231,10 @@ public function generateExportFileData($gridField)
                         }
 
                         $value = $columnHeader($relObj);
+                    } elseif ($gridFieldColumnsComponent) {
+                        $value = strip_tags(
+                            $gridFieldColumnsComponent->getColumnContent($gridField, $item, $columnSource)
+                        );
                     } else {
                         $value = $gridField->getDataFieldValue($item, $columnSource);
 

diff --git a/src/Forms/GridField/GridFieldPrintButton.php b/src/Forms/GridField/GridFieldPrintButton.php
@@ -156,7 +156,7 @@ protected function getPrintColumnsForGridField(GridField $gridField)
         }
 
         /** @var GridFieldDataColumns $dataCols */
-        $dataCols = $gridField->getConfig()->getComponentByType('SilverStripe\\Forms\\GridField\\GridFieldDataColumns');
+        $dataCols = $gridField->getConfig()->getComponentByType(GridFieldDataColumns::class);
         if ($dataCols) {
             return $dataCols->getDisplayFields($gridField);
         }
@@ -223,12 +223,17 @@ public function generatePrintData(GridField $gridField)
         $items = $gridField->getManipulatedList();
         $itemRows = new ArrayList();
 
+        /** @var GridFieldDataColumns $gridFieldColumnsComponent */
+        $gridFieldColumnsComponent = $gridField->getConfig()->getComponentByType(GridFieldDataColumns::class);
+
         /** @var DataObject $item */
         foreach ($items->limit(null) as $item) {
             $itemRow = new ArrayList();
 
             foreach ($printColumns as $field => $label) {
-                $value = $gridField->getDataFieldValue($item, $field);
+                $value = $gridFieldColumnsComponent
+                    ? strip_tags($gridFieldColumnsComponent->getColumnContent($gridField, $item, $field))
+                    : $gridField->getDataFieldValue($item, $field);
 
                 $itemRow->push(new ArrayData(array(
                     "CellString" => $value,