BUGFIX: Fixed notice-level errors in GridField, exposed by test failu…

…res.
silverstripe · Jan 10, 2012 · 489191b · 489191b
1 parent 06605ff
commit 489191b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 11 deletions.
diff --git a/forms/gridfield/GridField.php b/forms/gridfield/GridField.php
@@ -399,8 +399,8 @@ public function getColumnContent($record, $column) {
 			$this->buildColumnDispatch();
 		}
 
-		$handler = $this->columnDispatch[$column];
-		if($handler) {
+		if(!empty($this->columnDispatch[$column])) {
+			$handler = $this->columnDispatch[$column];
 			return $handler->getColumnContent($this, $record, $column);
 		} else {
 			throw new InvalidArgumentException("Bad column '$column'");
@@ -422,8 +422,8 @@ public function getColumnAttributes($record, $column) {
 			$this->buildColumnDispatch();
 		}
 
-		$handler = $this->columnDispatch[$column];
-		if($handler) {
+		if(!empty($this->columnDispatch[$column])) {
+			$handler = $this->columnDispatch[$column];
 			$attrs =  $handler->getColumnAttributes($this, $record, $column);
 			if(is_array($attrs)) {
 				return $attrs;
@@ -451,8 +451,8 @@ public function getColumnMetadata($column) {
 			$this->buildColumnDispatch();
 		}
 
-		$handler = $this->columnDispatch[$column];
-		if($handler) {
+		if(!empty($this->columnDispatch[$column])) {
+			$handler = $this->columnDispatch[$column];
 			$metadata = $handler->getColumnMetadata($this, $column);
 			if(is_array($metadata)) {
 				return $metadata;
@@ -502,13 +502,12 @@ public function gridFieldAlterAction($data, $form, SS_HTTPRequest $request) {
 		$stateChange = Session::get($id);
 		$gridName = $stateChange['grid'];
 		$grid = $form->Fields()->dataFieldByName($gridName);
-
+		
 		$state = $grid->getState(false);
-		$state->setValue($data['GridState']);
+		if(isset($data['GridState'])) $state->setValue($data['GridState']);
 
 		$actionName = $stateChange['actionName'];
-
-		$args = $stateChange['args'];
+		$args = isset($stateChange['args']) ? $stateChange['args'] : array();
 		$grid->handleAction($actionName, $args, $data);
 
 		switch($request->getHeader('X-Get-Fragment')) {

diff --git a/tests/forms/GridFieldTest.php b/tests/forms/GridFieldTest.php
@@ -315,7 +315,7 @@ public function testGridFieldAlterAction() {
 		$obj = new GridField('testfield', 'testfield', ArrayList::create(), $config);
 		$id = 'testGridStateActionField';
 		Session::set($id, array('grid'=>'', 'actionName'=>'jump'));
-		$form = new Form($this, 'mockform', new FieldList(array($obj)), new FieldList());
+		$form = new Form(new Controller(), 'mockform', new FieldList(array($obj)), new FieldList());
 		$request = new SS_HTTPRequest('POST', 'url');
 		$obj->gridFieldAlterAction(array('StateID'=>$id), $form, $request);
 	}