Permalink
Browse files

MINOR Reverted r105264, breaks CompositeFieldTest, FieldSetTest, Tran…

…slatableTest (from r105274)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112474 467b73ca-7a2a-4603-9d3b-597d59a354a9
  • Loading branch information...
1 parent bcbe9c2 commit 68fcd8c94f29a81328adcfb06b4f681782efde5b @chillu chillu committed Oct 15, 2010
Showing with 1 addition and 2 deletions.
  1. +1 −2 forms/FieldSet.php
View
@@ -335,8 +335,7 @@ public function insertBefore($item, $name) {
$i = 0;
foreach($this->items as $child) {
if($name == $child->Name() || $name == $child->id) {
- // On PHP 5.2.6, using $this->items directly in array_splice can segfault
- $itms = $this->items; array_splice($itms, $i, 0, array($item));
+ array_splice($this->items, $i, 0, array($item));
return $item;
} elseif($child->isComposite()) {
$ret = $child->insertBefore($item, $name);

0 comments on commit 68fcd8c

Please sign in to comment.