Skip to content

Commit

Permalink
NEW Add exists as a method to the DataQuery API that will generate an…
Browse files Browse the repository at this point in the history
… SQL "exists" query

The exists query in SQL allows the query optimiser (engine specific) to execute these queries much faster - often only needing the presence of an index to return "yes it exists".
  • Loading branch information
ScopeyNZ committed Apr 14, 2019
1 parent 2c971ee commit 81e39aa
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/ORM/DataList.php
Original file line number Diff line number Diff line change
Expand Up @@ -932,7 +932,7 @@ public function last()
*/
public function exists()
{
return $this->count() > 0;
return $this->dataQuery->exists();
}

/**
Expand Down
29 changes: 29 additions & 0 deletions src/ORM/DataQuery.php
Original file line number Diff line number Diff line change
Expand Up @@ -447,6 +447,35 @@ public function count()
return $this->getFinalisedQuery()->count("DISTINCT {$quotedColumn}");
}

/**
* Return whether this dataquery will have records. This will use `EXISTS` statements in SQL which are more
* performant - especially when used in combination with indexed columns (that you're filtering on)
*
* @return bool
*/
public function exists()
{
// Grab a statement selecting "everything" - the engine shouldn't care what's being selected in an "EXISTS"
// statement anyway
$statement = $this->getFinalisedQuery();
$statement->setSelect('*');

// Clear limit, distinct, grouping, and order as it's not relevant for an exists query
$statement->setDistinct(false);
$statement->setOrderBy(null);
$statement->setGroupBy(null);
$statement->setLimit(null);

// Wrap the whole thing in an "EXISTS"
$sql = 'SELECT EXISTS(' . $statement->sql($params) . ')';
$result = DB::prepared_query($sql, $params);
$row = $result->first();
$result = reset($row);

// Checking for 't' supports PostgreSQL before silverstripe/postgresql@2.2
return $result === 1 || $result === 't';
}

/**
* Return the maximum value of the given field in this DataList
*
Expand Down

0 comments on commit 81e39aa

Please sign in to comment.