Skip to content

Commit

Permalink
MINOR Removed jQuery.metadata usage in CMS, use jQuery.data() and HTM…
Browse files Browse the repository at this point in the history
…L5 data attributes instead. Also fixes errors where jQuery.metadata tries to eval() HTML5 data attrs, which isn't always applicable
  • Loading branch information
chillu committed Feb 17, 2012
1 parent 9190bc4 commit ac56fef
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
1 change: 0 additions & 1 deletion admin/code/LeftAndMain.php
Expand Up @@ -239,7 +239,6 @@ function init() {
THIRDPARTY_DIR . '/jquery-cookie/jquery.cookie.js', THIRDPARTY_DIR . '/jquery-cookie/jquery.cookie.js',
THIRDPARTY_DIR . '/jquery-query/jquery.query.js', THIRDPARTY_DIR . '/jquery-query/jquery.query.js',
SAPPHIRE_ADMIN_DIR . '/thirdparty/jquery-notice/jquery.notice.js', SAPPHIRE_ADMIN_DIR . '/thirdparty/jquery-notice/jquery.notice.js',
THIRDPARTY_DIR . '/jquery-metadata/jquery.metadata.js',
SAPPHIRE_ADMIN_DIR . '/thirdparty/jsizes/lib/jquery.sizes.js', SAPPHIRE_ADMIN_DIR . '/thirdparty/jsizes/lib/jquery.sizes.js',
SAPPHIRE_ADMIN_DIR . '/thirdparty/jlayout/lib/jlayout.border.js', SAPPHIRE_ADMIN_DIR . '/thirdparty/jlayout/lib/jlayout.border.js',
SAPPHIRE_ADMIN_DIR . '/thirdparty/jlayout/lib/jquery.jlayout.js', SAPPHIRE_ADMIN_DIR . '/thirdparty/jlayout/lib/jquery.jlayout.js',
Expand Down
4 changes: 1 addition & 3 deletions admin/javascript/LeftAndMain.js
Expand Up @@ -4,8 +4,6 @@ jQuery.noConflict();
* File: LeftAndMain.js * File: LeftAndMain.js
*/ */
(function($) { (function($) {
$.metadata.setType('html5');

// setup jquery.entwine // setup jquery.entwine
$.entwine.warningLevel = $.entwine.WARN_LEVEL_BESTPRACTISE; $.entwine.warningLevel = $.entwine.WARN_LEVEL_BESTPRACTISE;
$.entwine('ss', function($) { $.entwine('ss', function($) {
Expand Down Expand Up @@ -347,7 +345,7 @@ jQuery.noConflict();
*/ */
$('.cms-container .field.date input.text').entwine({ $('.cms-container .field.date input.text').entwine({
onmatch: function() { onmatch: function() {
var holder = $(this).parents('.field.date:first'), config = holder.metadata({type: 'class'}); var holder = $(this).parents('.field.date:first'), config = holder.data();
if(!config.showcalendar) return; if(!config.showcalendar) return;


config.showOn = 'button'; config.showOn = 'button';
Expand Down

0 comments on commit ac56fef

Please sign in to comment.