FIX Improve rounding logic for storing of long decimal numbers (#10593)

Co-authored-by: Michal Kleiner <michal.kleiner@cub3.com>
silverstripe · Nov 29, 2022 · b107622 · b107622
1 parent f57a77d
commit b107622
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 3 deletions.
diff --git a/src/ORM/FieldType/DBDecimal.php b/src/ORM/FieldType/DBDecimal.php
@@ -126,7 +126,7 @@ public function prepValueForDB($value)
             return 0;
         }
 
-        if (ctype_digit((string) $value)) {
+        if (abs((float) $value - (int) $value) < PHP_FLOAT_EPSILON) {
             return (int)$value;
         }
 

diff --git a/tests/php/ORM/DecimalTest.php b/tests/php/ORM/DecimalTest.php
@@ -61,6 +61,35 @@ public function testSpecifiedDefaultValueInDefaultsArray()
         );
     }
 
+    public function testLongValueStoredCorrectly()
+    {
+        $this->assertEquals(
+            $this->testDataObject->MyDecimal5,
+            1.0,
+            'Long default long decimal value is rounded correctly'
+        );
+
+        $this->assertEqualsWithDelta(
+            $this->testDataObject->MyDecimal5,
+            0.99999999999999999999,
+            PHP_FLOAT_EPSILON,
+            'Long default long decimal value is correct within float epsilon'
+        );
+
+        $this->assertEquals(
+            $this->testDataObject->MyDecimal6,
+            8.0,
+            'Long decimal value with a default value is rounded correctly'
+        );
+
+        $this->assertEqualsWithDelta(
+            $this->testDataObject->MyDecimal6,
+            7.99999999999999999999,
+            PHP_FLOAT_EPSILON,
+            'Long decimal value is within epsilon if longer than allowed number of float digits'
+        );
+    }
+
     public function testScaffoldFormField()
     {
         /** @var DBDecimal $decimal */

diff --git a/tests/php/ORM/DecimalTest/TestObject.php b/tests/php/ORM/DecimalTest/TestObject.php
@@ -14,10 +14,13 @@ class TestObject extends DataObject implements TestOnly
         'MyDecimal1' => 'Decimal',
         'MyDecimal2' => 'Decimal(5,3,2.5)',
         'MyDecimal3' => 'Decimal(4,2,"Invalid default value")',
-        'MyDecimal4' => 'Decimal'
+        'MyDecimal4' => 'Decimal',
+        'MyDecimal5' => 'Decimal(20,18,0.99999999999999999999)',
+        'MyDecimal6' => 'Decimal',
     ];
 
     private static $defaults = [
-        'MyDecimal4' => 4
+        'MyDecimal4' => 4,
+        'MyDecimal6' => 7.99999999999999999999,
     ];
 }