Skip to content

Commit

Permalink
BUGFIX: Use the copy of symfony-yaml bundled with Zend_Translate to p…
Browse files Browse the repository at this point in the history
…revent class conflicts. Remove now-unnecessary symonfy-yaml thirdparty lib.
  • Loading branch information
Sam Minnee committed Apr 17, 2012
1 parent cde9b31 commit cc7a012
Show file tree
Hide file tree
Showing 14 changed files with 4 additions and 2,151 deletions.
5 changes: 2 additions & 3 deletions core/manifest/ConfigManifest.php
Original file line number Diff line number Diff line change
Expand Up @@ -176,9 +176,8 @@ public function addYAMLConfigFile($basename, $pathname, $depth) {
// Keep track of all the modules we've seen
$this->addModule(dirname(dirname($pathname)));

// We use Symfony Yaml since it's the most complete. It still doesn't handle all of YAML, but it's better than
// nothing.
if(!class_exists('sfYamlParser', false)) require_once 'thirdparty/symfony-yaml/lib/sfYamlParser.php';
// Use the Zend copy of this script to prevent class conflicts when RailsYaml is included
require_once 'thirdparty/zend_translate_railsyaml/library/Translate/Adapter/thirdparty/sfYaml/lib/sfYamlParser.php';
$parser = new sfYamlParser();

// The base header
Expand Down
4 changes: 2 additions & 2 deletions i18n/i18nTextCollector.php
Original file line number Diff line number Diff line change
Expand Up @@ -495,8 +495,8 @@ public function write($entities, $locale, $path) {
}

public function getYaml($entities, $locale) {
// Check required because Zend_Translate_RailsYAML also includes the lib, from a different location
if(!class_exists('sfYamlDumper', false)) require_once 'thirdparty/symfony-yaml/lib/sfYamlDumper.php';
// Use the Zend copy of this script to prevent class conflicts when RailsYaml is included
require_once 'thirdparty/zend_translate_railsyaml/library/Translate/Adapter/thirdparty/sfYaml/lib/sfYamlDumper.php';

// Unflatten array
$entitiesNested = array();
Expand Down
8 changes: 0 additions & 8 deletions thirdparty/symfony-yaml/.piston.yml

This file was deleted.

19 changes: 0 additions & 19 deletions thirdparty/symfony-yaml/LICENSE

This file was deleted.

15 changes: 0 additions & 15 deletions thirdparty/symfony-yaml/README.markdown

This file was deleted.

143 changes: 0 additions & 143 deletions thirdparty/symfony-yaml/doc/00-Introduction.markdown

This file was deleted.

110 changes: 0 additions & 110 deletions thirdparty/symfony-yaml/doc/01-Usage.markdown

This file was deleted.

Loading

0 comments on commit cc7a012

Please sign in to comment.