Skip to content
This repository
Browse code

BUG Consistently self-closing form field tags (#7557)

This is reverting templates back to pre-3.0 conventions,
which were dominated by XHTML templates.
HTML5 allows both self-closing and unclosed tags,
so opting for self-closing to achieve maximum compatibility.
  • Loading branch information...
commit ce2d31b060c2e7d976eb9e192b4a186828ec103b 1 parent b649c09
Ingo Schommer authored August 10, 2012
2  templates/forms/CheckboxField.ss
... ...
@@ -1 +1 @@
1  
-<input $AttributesHTML>
  1
+<input $AttributesHTML />
2  templates/forms/CheckboxSetField.ss
@@ -2,7 +2,7 @@
2 2
 	<% if Options.Count %>
3 3
 		<% loop Options %>
4 4
 			<li class="$Class">
5  
-				<input id="$ID" class="checkbox" name="$Name" type="checkbox" value="$Value"<% if isChecked %> checked="checked"<% end_if %><% if isDisabled %> disabled="disabled"<% end_if %>>
  5
+				<input id="$ID" class="checkbox" name="$Name" type="checkbox" value="$Value"<% if isChecked %> checked="checked"<% end_if %><% if isDisabled %> disabled="disabled"<% end_if %> />
6 6
 				<label for="$ID">$Title</label>
7 7
 			</li> 
8 8
 		<% end_loop %>
4  templates/forms/FileField.ss
... ...
@@ -1,2 +1,2 @@
1  
-<input $AttributesHTML>
2  
-<input type="hidden" name="MAX_FILE_SIZE" value="$MaxFileSize">
  1
+<input $AttributesHTML />
  2
+<input type="hidden" name="MAX_FILE_SIZE" value="$MaxFileSize" />
2  templates/forms/FormAction.ss
@@ -3,5 +3,5 @@
3 3
 		<% if ButtonContent %>$ButtonContent<% else %>$Title<% end_if %>
4 4
 	</button>
5 5
 <% else %>
6  
-	<input $AttributesHTML>
  6
+	<input $AttributesHTML />
7 7
 <% end_if %>
2  templates/forms/FormField.ss
@@ -5,5 +5,5 @@
5 5
 		$Value
6 6
 	</span>
7 7
 <% else %>
8  
-	<input $AttributesHTML>
  8
+	<input $AttributesHTML />
9 9
 <% end_if %>
2  templates/forms/OptionsetField.ss
... ...
@@ -1,7 +1,7 @@
1 1
 <ul id="$ID" class="$extraClass"<% if Description %> title="$Description"<% end_if %>>
2 2
 	<% loop Options %>
3 3
 		<li class="$Class">
4  
-			<input id="$ID" class="radio" name="$Name" type="radio" value="$Value"<% if isChecked %> checked<% end_if %><% if isDisabled %> disabled<% end_if %>>
  4
+			<input id="$ID" class="radio" name="$Name" type="radio" value="$Value"<% if isChecked %> checked<% end_if %><% if isDisabled %> disabled<% end_if %> />
5 5
 			<label for="$ID">$Title</label>
6 6
 		</li>
7 7
 	<% end_loop %>

0 notes on commit ce2d31b

Please sign in to comment.
Something went wrong with that request. Please try again.