Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

BUG Consistently self-closing form field tags (#7557)

This is reverting templates back to pre-3.0 conventions,
which were dominated by XHTML templates.
HTML5 allows both self-closing and unclosed tags,
so opting for self-closing to achieve maximum compatibility.
  • Loading branch information...
commit ce2d31b060c2e7d976eb9e192b4a186828ec103b 1 parent b649c09
@chillu chillu authored
View
2  templates/forms/CheckboxField.ss
@@ -1 +1 @@
-<input $AttributesHTML>
+<input $AttributesHTML />
View
2  templates/forms/CheckboxSetField.ss
@@ -2,7 +2,7 @@
<% if Options.Count %>
<% loop Options %>
<li class="$Class">
- <input id="$ID" class="checkbox" name="$Name" type="checkbox" value="$Value"<% if isChecked %> checked="checked"<% end_if %><% if isDisabled %> disabled="disabled"<% end_if %>>
+ <input id="$ID" class="checkbox" name="$Name" type="checkbox" value="$Value"<% if isChecked %> checked="checked"<% end_if %><% if isDisabled %> disabled="disabled"<% end_if %> />
<label for="$ID">$Title</label>
</li>
<% end_loop %>
View
4 templates/forms/FileField.ss
@@ -1,2 +1,2 @@
-<input $AttributesHTML>
-<input type="hidden" name="MAX_FILE_SIZE" value="$MaxFileSize">
+<input $AttributesHTML />
+<input type="hidden" name="MAX_FILE_SIZE" value="$MaxFileSize" />
View
2  templates/forms/FormAction.ss
@@ -3,5 +3,5 @@
<% if ButtonContent %>$ButtonContent<% else %>$Title<% end_if %>
</button>
<% else %>
- <input $AttributesHTML>
+ <input $AttributesHTML />
<% end_if %>
View
2  templates/forms/FormField.ss
@@ -5,5 +5,5 @@
$Value
</span>
<% else %>
- <input $AttributesHTML>
+ <input $AttributesHTML />
<% end_if %>
View
2  templates/forms/OptionsetField.ss
@@ -1,7 +1,7 @@
<ul id="$ID" class="$extraClass"<% if Description %> title="$Description"<% end_if %>>
<% loop Options %>
<li class="$Class">
- <input id="$ID" class="radio" name="$Name" type="radio" value="$Value"<% if isChecked %> checked<% end_if %><% if isDisabled %> disabled<% end_if %>>
+ <input id="$ID" class="radio" name="$Name" type="radio" value="$Value"<% if isChecked %> checked<% end_if %><% if isDisabled %> disabled<% end_if %> />
<label for="$ID">$Title</label>
</li>
<% end_loop %>
Please sign in to comment.
Something went wrong with that request. Please try again.