Skip to content

Commit

Permalink
BUG Consistently self-closing form field tags (#7557)
Browse files Browse the repository at this point in the history
This is reverting templates back to pre-3.0 conventions,
which were dominated by XHTML templates.
HTML5 allows both self-closing and unclosed tags,
so opting for self-closing to achieve maximum compatibility.
  • Loading branch information
chillu committed Aug 10, 2012
1 parent b649c09 commit ce2d31b
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion templates/forms/CheckboxField.ss
@@ -1 +1 @@
<input $AttributesHTML>
<input $AttributesHTML />
2 changes: 1 addition & 1 deletion templates/forms/CheckboxSetField.ss
Expand Up @@ -2,7 +2,7 @@
<% if Options.Count %>
<% loop Options %>
<li class="$Class">
<input id="$ID" class="checkbox" name="$Name" type="checkbox" value="$Value"<% if isChecked %> checked="checked"<% end_if %><% if isDisabled %> disabled="disabled"<% end_if %>>
<input id="$ID" class="checkbox" name="$Name" type="checkbox" value="$Value"<% if isChecked %> checked="checked"<% end_if %><% if isDisabled %> disabled="disabled"<% end_if %> />
<label for="$ID">$Title</label>
</li>
<% end_loop %>
Expand Down
4 changes: 2 additions & 2 deletions templates/forms/FileField.ss
@@ -1,2 +1,2 @@
<input $AttributesHTML>
<input type="hidden" name="MAX_FILE_SIZE" value="$MaxFileSize">
<input $AttributesHTML />
<input type="hidden" name="MAX_FILE_SIZE" value="$MaxFileSize" />
2 changes: 1 addition & 1 deletion templates/forms/FormAction.ss
Expand Up @@ -3,5 +3,5 @@
<% if ButtonContent %>$ButtonContent<% else %>$Title<% end_if %>
</button>
<% else %>
<input $AttributesHTML>
<input $AttributesHTML />
<% end_if %>
2 changes: 1 addition & 1 deletion templates/forms/FormField.ss
Expand Up @@ -5,5 +5,5 @@
$Value
</span>
<% else %>
<input $AttributesHTML>
<input $AttributesHTML />
<% end_if %>
2 changes: 1 addition & 1 deletion templates/forms/OptionsetField.ss
@@ -1,7 +1,7 @@
<ul id="$ID" class="$extraClass"<% if Description %> title="$Description"<% end_if %>>
<% loop Options %>
<li class="$Class">
<input id="$ID" class="radio" name="$Name" type="radio" value="$Value"<% if isChecked %> checked<% end_if %><% if isDisabled %> disabled<% end_if %>>
<input id="$ID" class="radio" name="$Name" type="radio" value="$Value"<% if isChecked %> checked<% end_if %><% if isDisabled %> disabled<% end_if %> />
<label for="$ID">$Title</label>
</li>
<% end_loop %>
Expand Down

0 comments on commit ce2d31b

Please sign in to comment.