Merge pull request #7186 from dhensby/pulls/3.5/cache-prefix

FIX Add unique prefix to cache stores to prevent cache leak
silverstripe · Jul 18, 2017 · d053c9a · d053c9a
2 parents fa8f0cc + b77274c
commit d053c9a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/cache/Cache.php b/cache/Cache.php
@@ -174,7 +174,9 @@ public static function factory($for, $frontend='Output', $frontendOptions=null)
 
 		$backend = self::$backends[$backend_name];
 
-		$basicOptions = array('cache_id_prefix' => $for);
+		$basicOptions = array(
+		    'cache_id_prefix' => $for . '_' . md5(BASE_PATH) . '_',
+        );
 
 		if ($cache_lifetime >= 0) {
 			$basicOptions['lifetime'] = $cache_lifetime;

diff --git a/core/manifest/ConfigManifest.php b/core/manifest/ConfigManifest.php
@@ -115,7 +115,8 @@ protected function getCache()
 	{
 		return SS_Cache::factory('SS_Configuration', 'Core', array(
 			'automatic_serialization' => true,
-			'lifetime' => null
+			'lifetime' => null,
+			'cache_id_prefix' => 'SS_Configuration_',
 		));
 	}