BUG Fix writeBaseRecord with unique indexes

Fixes #6819
silverstripe · Feb 27, 2019 · d1396b7 · d1396b7
1 parent ed013fc
commit d1396b7
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 5 deletions.
diff --git a/src/ORM/DataObject.php b/src/ORM/DataObject.php
@@ -1413,8 +1413,10 @@ protected function prepareManipulationTable($baseTable, $now, $isNewRecord, &$ma
         // Inserts done one the base table are performed in another step, so the manipulation should instead
         // attempt an update, as though it were a normal update.
         $manipulation[$table]['command'] = $isNewRecord ? 'insert' : 'update';
-        $manipulation[$table]['id'] = $this->record['ID'];
         $manipulation[$table]['class'] = $class;
+        if ($this->isInDB()) {
+            $manipulation[$table]['id'] = $this->record['ID'];
+        }
     }
 
     /**
@@ -1433,10 +1435,10 @@ protected function writeBaseRecord($baseTable, $now)
         }
 
         // Perform an insert on the base table
-        $insert = new SQLInsert('"' . $baseTable . '"');
-        $insert
-            ->assign('"Created"', $now)
-            ->execute();
+        $manipulation = [];
+        $this->prepareManipulationTable($baseTable, $now, true, $manipulation, $this->baseClass());
+        DB::manipulate($manipulation);
+
         $this->changed['ID'] = self::CHANGE_VALUE;
         $this->record['ID'] = DB::get_generated_id($baseTable);
     }

diff --git a/tests/php/ORM/DataObjectSchemaTest.php b/tests/php/ORM/DataObjectSchemaTest.php
@@ -343,4 +343,35 @@ public function testFieldsCanBeIndexedFromFieldSpecs()
             'columns' => ['IndexedMoneyCurrency', 'IndexedMoneyAmount']
         ], $indexes['IndexedMoney']);
     }
+
+    /**
+     * Ensure that records with unique indexes can be written
+     */
+    public function testWriteUniqueIndexes()
+    {
+        // Create default object
+        $zeroObject = new AllIndexes();
+        $zeroObject->Number = 0;
+        $zeroObject->write();
+
+        $this->assertListEquals(
+            [
+                ['Number' => 0],
+            ],
+            AllIndexes::get()
+        );
+
+        // Test a new record can be created without clashing with default value
+        $validObject = new AllIndexes();
+        $validObject->Number = 1;
+        $validObject->write();
+
+        $this->assertListEquals(
+            [
+                ['Number' => 0],
+                ['Number' => 1],
+            ],
+            AllIndexes::get()
+        );
+    }
 }
diff --git a/tests/php/ORM/DataObjectSchemaTest/AllIndexes.php b/tests/php/ORM/DataObjectSchemaTest/AllIndexes.php
@@ -5,6 +5,11 @@
 use SilverStripe\ORM\DataObject;
 use SilverStripe\ORM\FieldType\DBIndexable;
 
+/**
+ * @property int $Number
+ * @property string $Content
+ * @property string $Title
+ */
 class AllIndexes extends DataObject implements TestOnly
 {
     private static $table_name = 'DataObjectSchemaTest_AllIndexes';