New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DevelopmentAdmin class tidy-up #10999

Open

4 tasks

sabina-talipova opened this issue Oct 18, 2023 · 0 comments

Labels

Milestone

Contributor

sabina-talipova commented Oct 18, 2023 •

edited by GuySartorelli

Loading

Description

documentation for how to add new tasks/sections
do we need buildDefaults and generatesecuretoken? if so, register in the list but if not, remove them.
cleanup errors() it's not even an allowed action, so can go
cleanup index() html building

See:

silverstripe-framework/src/Dev/DevelopmentAdmin.php

Lines 23 to 26 in cf78a9d

    
            * @todo documentation for how to add new unit tests and tasks 
        
            * @todo do we need buildDefaults and generatesecuretoken? if so, register in the list 
        
            * @todo cleanup errors() it's not even an allowed action, so can go 
        
            * @todo cleanup index() html building

sabina-talipova added type/enhancement affects/v5 labels

This was referenced Oct 18, 2023

Remove all TODO comments in the code silverstripe/.github#116

Closed

MNT Remove TODO comments #11032

Merged

GuySartorelli added type/api-break and removed type/enhancement affects/v5 labels

GuySartorelli added this to the Silverstripe CMS 6 milestone

GuySartorelli changed the title ~~TODO: DevelopmentAdmin class improvements~~ DevelopmentAdmin class improvements

GuySartorelli changed the title ~~DevelopmentAdmin class improvements~~ DevelopmentAdmin class tidy-up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment