Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO: Update the expectation in CurrencyFieldReadonlyTest and CurrencyFieldDisabledTest #11013

Closed
sabina-talipova opened this issue Oct 18, 2023 · 1 comment
Closed

TODO: Update the expectation in CurrencyFieldReadonlyTest and CurrencyFieldDisabledTest #11013

sabina-talipova opened this issue Oct 18, 2023 · 1 comment
Labels
affects/v5 type/enhancement

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Oct 18, 2023 •
edited
Loading

Description

Update the expectation in CurrencyFieldReadonlyTest::testFieldWithCustomisedCurrencySymbol and CurrencyFieldDisabledTest::testFieldWithCustomisedCurrencySymbol when intl for currencies is implemented.

See:

silverstripe-framework/tests/php/Forms/CurrencyFieldReadonlyTest.php

Line 41 in cf78a9d

* @todo: Update the expectation when intl for currencies is implemented

@sabina-talipova sabina-talipova changed the title TODO: Update the expectation in CurrencyFieldReadonlyTest::testFieldWithCustomisedCurrencySymbol TODO: Update the expectation in CurrencyFieldReadonlyTest and CurrencyFieldDisabledTest Oct 18, 2023
This was referenced Oct 18, 2023
Closed
Merged
@GuySartorelli
Copy link
Member

Gonna close this - we will naturally add test coverage when/if we implement that functionality.

@GuySartorelli GuySartorelli closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v5 type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GuySartorelli @sabina-talipova