Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge arrays recursively for FormField::setSchemaState and FormField::setSchemaData #11022

Open
sabina-talipova opened this issue Oct 18, 2023 · 0 comments
Open

Merge arrays recursively for FormField::setSchemaState and FormField::setSchemaData #11022

sabina-talipova opened this issue Oct 18, 2023 · 0 comments
Labels
affects/v5 type/enhancement

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Oct 18, 2023 •
edited by GuySartorelli

Description

Add deep merging of arrays like data and attributes into FormField::setSchemaData and FormField::setSchemaState.

Probably just use ArrayLib::array_merge_recursive()

See:

silverstripe-framework/src/Forms/FormField.php

Line 1429 in cf78a9d

* @todo Add deep merging of arrays like `data` and `attributes`.

See:

silverstripe-framework/src/Forms/FormField.php

Line 1505 in cf78a9d

* @todo Add deep merging of arrays like `data` and `attributes`.

This was referenced Oct 18, 2023
Closed
Merged
@GuySartorelli GuySartorelli changed the title TODO: FormField - Add deep merging of arrays like data and attributes Merge arrays recursively for FormField::setSchemaState and FormField::setSchemaData Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v5 type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sabina-talipova