Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2010-07-11] Partial Caching should invalidate on ?flush=all #1383

Closed
silverstripe-issues opened this issue Apr 3, 2013 · 4 comments
Closed

Comments

@silverstripe-issues
Copy link

created by: @chillu (ischommer)
assigned to: hfried
created at: 2010-07-11
original ticket: http://open.silverstripe.org/ticket/5807


Currently its too complicated to invalidate partial caches in templates (you basically have to comment out the <% cache %> part. I've talked to Hamish a while ago, we think it'd be more intuitive to invalidate caches on ?flush=all as well (it roughly fits in the "clear template cache" thinking). This has to be limited to ADMIN access of course, to avoid denial of service attacks.

@halkyon
Copy link
Contributor

halkyon commented Nov 3, 2013

This is something I ended up doing in my own _config.php on a project, seems like a good idea for it to happen in the core though.

@froog
Copy link
Contributor

froog commented Dec 19, 2013

+1 for this feature, I always thought it strange (and frustrating) that ?flush=all didn't clear partial caches.

@simonwelsh simonwelsh added this to the 3.2 milestone Mar 15, 2014
@kinglozzer
Copy link
Member

Well, it seems this feature was accidentally added in d3b63da, and then accidentally removed by me in d012b79. Shouldn’t be too hard to implement, just need to flush the cache named “cacheblock”.

I appreciate this should be master, but would it be better to make this 3.1 instead? Given that the behaviour, although a bug, has existed throughout versions 3.0 - 3.1.5.

@kinglozzer
Copy link
Member

Scratch that, it seems the new Flushable stuff has resolved this

halkyon pushed a commit that referenced this issue Oct 10, 2014
…al-cache

FIX: Deliberately clear partial cache blocks on flush (fixes #1383)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants