Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2012-07-23] Content subtemplates no longer usable with SiteTree #1544

Closed
silverstripe-issues opened this issue Apr 3, 2013 · 0 comments
Closed

Comments

@silverstripe-issues
Copy link

created by: jedateach
created at: 2012-07-23
original ticket: http://open.silverstripe.org/ticket/7692


This may be a bug or a decided implementation approach that needs to be documented.

When making use of the Content/ templates folder in 2.4, the template took precedence over fields i.e. the Content SiteTree db field (or function) was overridden by the appropriate template, if found in the Content folder. I have found this technique to be very useful.

This has reversed in SS3. The db variable/ or function now takes precedence over the /Content/ template.

In my opinion, this ruins the opportunity to use 3rd-level subtemplating via $Content, as there is no clear way to get around this issue.

[https://github.com/silverstripe/sapphire/commit/521742aaf88bb2d48d56fa522483375c4dbe137e#L1L816 related commit]

[https://github.com//pull/661 My pull request, to revert the precedence as it was.]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants