Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't remove stuff from 3.x #4514

Closed
sminnee opened this issue Aug 20, 2015 · 2 comments
Closed

Don't remove stuff from 3.x #4514

sminnee opened this issue Aug 20, 2015 · 2 comments
Assignees
@tractorcow
Milestone
3.2.0 rc 1

Comments

@sminnee
Copy link
Member

sminnee commented Aug 20, 2015

We need to revert 404478b from the 3.2 and 3 branches, but not master.

These things shouldn't have been removed between 3.1 and 3.2.

The original PR #3396 was merged to master before be agreed semver and branched 3. :-(

I believe this blocks 3.2.0-rc1
@sminnee sminnee added this to the 3.2.0 rc 1 milestone Aug 20, 2015
@sminnee sminnee mentioned this issue Aug 20, 2015
Merged
@tractorcow
Copy link
Contributor

ok, I'll make sure this happens.

As an aside, some of the Aggregate functionality in the old code was removed because it was broken; I'll restore as much as I can that works still, of course. :)

@tractorcow
Copy link
Contributor

Also found #3425

tractorcow pushed a commit to tractorcow/silverstripe-framework that referenced this issue Aug 21, 2015
Revert silverstripe#3425 silverstripe#3396 to restore deprecated func…
a800786 
…tionality

Fixes silverstripe#4514
tractorcow pushed a commit to tractorcow/silverstripe-framework that referenced this issue Aug 21, 2015
Revert silverstripe#3425 silverstripe#3396 to restore deprecated func…
b2e2dd7 
…tionality

Fixes silverstripe#4514
@tractorcow tractorcow mentioned this issue Aug 21, 2015
Merged
@tractorcow tractorcow self-assigned this Aug 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tractorcow tractorcow

Labels
None yet
Projects
None yet
Milestone
3.2.0 rc 1
Development

No branches or pull requests
2 participants
@sminnee @tractorcow