Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard to debug custom rendered forms #6288

Closed
silbinarywolf opened this issue Nov 3, 2016 · 2 comments
Closed

Hard to debug custom rendered forms #6288

silbinarywolf opened this issue Nov 3, 2016 · 2 comments

Comments

@silbinarywolf
Copy link
Contributor

silbinarywolf commented Nov 3, 2016

When rendering a form without $FieldHolder, you can potentially lose important error messages and be stuck debugging a form that seems to 'randomly' redirect back in certain cases.

I propose that we add a flag per FormField that says whether a user has rendered $Message on each form field, and if they haven't, an exception is thrown with the unrendered FormField messages so that the developer knows where they went wrong.

Since this behaviour might not necessarily be what you want in certain cases, there should also be a config flag / property on 'Form' to disable this behaviour. I feel it should be enabled by default because a lot of new developers to Silverstripe get stuck on this and don't realize it's due to them not rendering the $FieldHolder.

I'm happy to do the work and PR, just running the idea by you guys first. Maybe SS 4.0 makes this redundant?

@silbinarywolf
Copy link
Contributor Author

Since there has been no discussion from other SSNZ team members, my assumption is that this is not a wanted feature.

@dhensby
Copy link
Contributor

dhensby commented Apr 18, 2018

sorry :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants