Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThemeManifest can't sort default module templates ($default set) #6828

Open
tractorcow opened this issue Apr 22, 2017 · 1 comment
Open

ThemeManifest can't sort default module templates ($default set) #6828

tractorcow opened this issue Apr 22, 2017 · 1 comment

Comments

@tractorcow
Copy link
Contributor

This is necessary to ensure that modules are sorted adequately, allowing non-core modules to override core.

Something similar to the i18n.module_priority could be used.

SilverStripe\i18n\i18n:
  module_priority:
    - silverstripe\cms
@tractorcow
Copy link
Contributor Author

Note that current order is alphabetic, and FIRST in the list is higher priority for template lookup (first found first returned).

array(9) {
  [0]=>
  string(12) "/asset-admin"
  [1]=>
  string(15) "/campaign-admin"
  [2]=>
  string(4) "/cms"
  [3]=>
  string(10) "/framework"
  [4]=>
  string(8) "/reports"
  [5]=>
  string(19) "/silverstripe-admin"
  [6]=>
  string(20) "/silverstripe-assets"
  [7]=>
  string(11) "/siteconfig"
  [8]=>
  string(12) "/testsession"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants