Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: It is possible to create a page with URLSegment admin #7139

Closed
Firesphere opened this issue Jul 6, 2017 · 3 comments
Closed

Bug: It is possible to create a page with URLSegment admin #7139

Firesphere opened this issue Jul 6, 2017 · 3 comments

Comments

@Firesphere
Copy link
Contributor

Firesphere commented Jul 6, 2017

/admin will still redirect to the CMS, but I feel it's kinda weird to allow it.

It allows for a CMSCeption to happen:
image

image

Or, why not edit users and pages at the same time?
image

I found this more hilarious even:
image

@Firesphere Firesphere changed the title It is possible to create a page with URLSegment admin [Feature|Bug] It is possible to create a page with URLSegment admin Jul 6, 2017
@sminnee
Copy link
Member

sminnee commented Jul 6, 2017

Anything that's got a director rule defined should be disallowed as a top-level page...

@SpiritLevel
Copy link
Contributor

SpiritLevel commented Jul 7, 2017 via email

@sminnee sminnee changed the title [Feature|Bug] It is possible to create a page with URLSegment admin Bug: It is possible to create a page with URLSegment admin Jul 7, 2017
Firesphere pushed a commit to Firesphere/silverstripe-cms that referenced this issue Jul 9, 2017
Firesphere pushed a commit to Firesphere/silverstripe-cms that referenced this issue Jul 9, 2017
Firesphere pushed a commit to Firesphere/silverstripe-cms that referenced this issue Jul 9, 2017
Firesphere pushed a commit to Firesphere/silverstripe-cms that referenced this issue Jul 9, 2017
Firesphere pushed a commit to Firesphere/silverstripe-cms that referenced this issue Jul 9, 2017
Firesphere pushed a commit to Firesphere/silverstripe-cms that referenced this issue Jul 23, 2017
Firesphere pushed a commit to Firesphere/silverstripe-cms that referenced this issue Jul 29, 2017
@Firesphere
Copy link
Contributor Author

Closing this issue as it's in CMS, not Framework, and PR is up here:
silverstripe/silverstripe-cms#1886

Firesphere pushed a commit to Firesphere/silverstripe-cms that referenced this issue Jul 29, 2017
Firesphere pushed a commit to Firesphere/silverstripe-cms that referenced this issue Jul 29, 2017
Firesphere pushed a commit to Firesphere/silverstripe-cms that referenced this issue Oct 13, 2017
Firesphere pushed a commit to Firesphere/silverstripe-cms that referenced this issue Oct 13, 2017
Fixes silverstripe/silverstripe-framework#7139

Move check for disallowed rules to validURLSegment
Firesphere pushed a commit to Firesphere/silverstripe-cms that referenced this issue Oct 13, 2017
Fixes silverstripe/silverstripe-framework#7139

Move check for disallowed rules to validURLSegment

Fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants