Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Surpress deprecation warnings on php7.4 #10043

Merged

Conversation

emteknetnz
Copy link
Member

Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use the [warning] syntax.

Comment on lines 18 to 23
```
Running CMS3 with PHP 7.4 will trigger a number of deprecation warnings.
It's highly recommended you disable deprecation warnings.
For instance on a dev environment add the following to the bottom of _ss_environment.php
error_reporting(E_ALL & ~E_DEPRECATED);
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```
Running CMS3 with PHP 7.4 will trigger a number of deprecation warnings.
It's highly recommended you disable deprecation warnings.
For instance on a dev environment add the following to the bottom of _ss_environment.php
error_reporting(E_ALL & ~E_DEPRECATED);
```
[warning]
Running CMS3 with PHP 7.4 triggers a number of deprecation warnings.
It's highly recommended you disable deprecation warnings.
For example, you can add the following to the bottom of your `_ss_environment.php` file:
`error_reporting(E_ALL & ~E_DEPRECATED);`
Read the [`error_reporting` PHP documentation](https://www.php.net/manual/en/function.error-reporting.php)
[/warning]

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@maxime-rainville maxime-rainville merged commit 52f9e28 into silverstripe:3 Aug 17, 2021
@maxime-rainville maxime-rainville deleted the pull/3/php74-deprecation branch August 17, 2021 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants