Add a basic ContentLocale method to controller #10081
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a basic ContentLocale method to controller that doesn't check a dataRecord.
Co-authored-by: Michal Kleiner <michal@michalkleiner.cz>
emteknetnz
requested changes
Sep 4, 2021
There was a problem hiding this comment.
I don't think Controller.php is really intended to serve content, that's what ContentController.php is for.
Reading through the issue, login-forms is a bit of a special case
I'm thinking a better approach would be to add the ContentLocale() method you've created and add it to https://github.com/silverstripe/silverstripe-login-forms/blob/4/src/EnablerExtension.php which is applied to Security.php
Closed
2 tasks
|
@TheBnl I've moved the issue to the login-forms module and I'll close this issue here. |
|
Moved issue — silverstripe/silverstripe-login-forms#100 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue https://github.com/silverstripe/silverstripe-framework/issues/10080
Add a basic ContentLocale method to controller that doesn't check a dataRecord.