Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Fixed issue where an undefined class error would be thrown when getting objects or ids from fixtures #10224

Merged

Conversation

UndefinedOffset
Copy link
Contributor

This pull request addresses an error saying that class SilverStripe\Dev\InvalidArgumentException is undefined if the class does not exist when calling SapphireTest::objFromFixture() or when calling SapphireTest::idFromFixture()`.

Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please instead add a use statement above use LogicException for consistency since InvalidArgumentException extends LogicException anyway? Thanks.

@UndefinedOffset
Copy link
Contributor Author

done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants