New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH Allow multiple backtick variables in a single value #10312
ENH Allow multiple backtick variables in a single value #10312
Conversation
Can you clarify what's the use case this enables that wasn't possible before ... if only for posterity. This also looks like something that should be documented in the changelog and/or doc? |
Required so that we can apply this config in the cwp-core PR
I've made a small update to the docs |
3207110
to
d0af1cb
Compare
I'll play the devil's advocate here this time... Should be targetting |
Yes normally I'd do This is ultimately to fix an issue that was spotted during beta regression testing |
1a84ca6
to
cf04bef
Compare
What's the expected behaviour if someone has config that looks like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual functionality looks good. Just some additional test cases to catch edge cases.
cf04bef
to
6a779d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Merge on green.
Once merged, kick off the tests again on silverstripe/cwp-core#107
#10305
Required for the config update in silverstripe/cwp-core#107