ENH Ensure users are sent emails when passwords are changed by default #10313
Conversation
|
Looks good. What was the rule around changing lang files through Transifex only? Does it also apply to default English files? |
|
I'm not sure, tbh... I think in this specific case it should be done here, since the translations were already pulled from transifex for this release as part of the beta. But I'm not sure what the general rule is for the default en files. |
There was a problem hiding this comment.
Just need to mention that there will be no behavioral change on sites with cwp/cwp-core installed
Also, would prefer that we only tried to fix one thing at a time. Even though it's more overhead, it's better to create a multiple PRs that each do a single thing.
@emteknetnz Fair enough - so you want three separate PRs for this? Or do you just want the changelog linting separate (since the other two are related to each other, but that's kinda separate)? |
|
The changelog modifications unrelated to the bug that's being fixed should be in its own PR Seems OK to keep the translation fix here since that's related to change password email that's being fixed |
|
Linting PR: #10314 |
GuySartorelli
force-pushed
the
pulls/4.11/email-when-password-changes
branch
from
f41069c
to
cec2576
Compare
|
While you’re in there, can you throw in a |
|
What's the use case for that? You can change the body of the email easily by just overriding the template, and the subject is passed through |
|
We typically run our email templates through a pair of templates: a wrapper that renders the $html = $data->renderWith(['App\Email\ForgotPasswordEmail', 'App\Email\Email']);
$email->setBody($html); |
|
That's fair - but should probably be done in a separate PR, since you'd probably want to add an extension point for the forgot email password as well - and maybe others. |
|
Separate PR would be better for the new extension point. |
Also a fix to remove the backslash that was being output in emails, and fixing some markdown linting issues in the changelog since I was already editing that file.
Note that each of the three commits has a different prefix for changelog purposes - no need to squash.
Parent issue