NEW add FormField updateSchemaData extension point #10328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an extension point to `FormField::getSchemaData()`
|
I wouldn't really want to be adding an extension hook for the purpose of working around a bug - it would be better if we can just fix the bug. |
|
+1 to that, but as the bug has been open since 2019 I'd given up much hope and couldn't think of another way than Loz's suggestion but that had recursion issues... |
|
I'm going to close this PR - if you find a way to fix the underlying bug please raise a PR for that, otherwise this will need to wait for someone to take some time to look into the bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an extension point to
FormField::getSchemaData()Related issue: silverstripe/silverstripe-elemental#738