MINOR: specify export fields on Model itself #10388
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinglozzer
requested changes
Jul 7, 2022
| $singleton = DataObject::singleton($gridField->getModelClass()); | ||
| if($singleton->hasMethod('getModelAdminExportFields')) { | ||
| return $singleton->getModelAdminExportFields(); | ||
| } |
There was a problem hiding this comment.
I think this block should come after if ($this->exportColumns) - if you manually specify fields against the GridField instance with ->setExportColumns() then that should take priority
|
This pull request hasn't had any activity for a while. Are you going to be doing further work on it, or would you prefer to close it now? |
|
It seems like there's going to be no further activity on this pull request, so we’ve closed it for now. Please open a new pull-request if you want to re-approach this work, or for anything else you think could be fixed or improved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to propose this change as it allows you to set export fields directtly on the model rather than relying on
summary_fieldsorthe gridfield display fields. I have never liked the way these two purposes were linked and this allows us to separate them.In other words, you may want to export more / different fields than just the ones displayed in the summary list in the gridfield.
If you like it then I can also add the documentation to go with it.