API Rescue Master Branch PR: Only expose public extension methods #10457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/5/rescue-master-extensions-expose-public
branch
from
c3930f9
to
11d8f23
Compare
5 tasks
GuySartorelli
changed the title
GuySartorelli
force-pushed
the
pulls/5/rescue-master-extensions-expose-public
branch
2 times, most recently
from
2dafffb
to
0a62ce7
Compare
|
PR is currently combination of 2x different things
These are two different things and should be done in separate PRs Cheers |
GuySartorelli
force-pushed
the
pulls/5/rescue-master-extensions-expose-public
branch
from
0a62ce7
to
bab1ed7
Compare
|
Strong-typing commit has been removed. |
added 2 commits
August 24, 2022 15:31
API Enable `extend*` methods to handle ->extend() API Remove Extensible::constructExtensions()
GuySartorelli
force-pushed
the
pulls/5/rescue-master-extensions-expose-public
branch
from
bab1ed7
to
f2211d6
Compare
emteknetnz
approved these changes
Aug 29, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rescues #7752 and #7879
Also strongly types
ExtensibleandCustomMethodsas per https://github.com/silverstripeltd/product-issues/issues/583 - easier to do it here while I'm already changing things than to do it as a follow-up PR, though I can happily remove that commit if the reviewer doesn't want them in the same PR.Depends on
Parent issues