Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Deprecate some unused API #11110

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Jan 16, 2024

Description

Deprecates some API that isn't in use anywhere and has no clear purpose.

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • tests aren't necessary for this change
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@GuySartorelli GuySartorelli force-pushed the pulls/5/deprecate-unused-methods branch from c6ad3d4 to 8b427f4 Compare January 17, 2024 01:01
@GuySartorelli GuySartorelli changed the title DEP Deprecate some unused API API Deprecate some unused API Jan 17, 2024
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge on green

@GuySartorelli GuySartorelli merged commit 583b762 into silverstripe:5 Jan 17, 2024
15 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5/deprecate-unused-methods branch January 17, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants