Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW HasOneRelationFieldInterface #11119

Conversation

emteknetnz
Copy link
Member

Issue silverstripe/silverstripe-linkfield#69

Creating an interface in framework so that it can be added to classes, rather than having to hardcode them in RequiredFields

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible. One day we should really revisit how required fields are defined and validated, but for now this enhances a capability for us to use in multiple places, so it's a good improvement.

@GuySartorelli GuySartorelli merged commit 05279f0 into silverstripe:5 Jan 31, 2024
15 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5/has-one-relation-field-interface branch January 31, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants