FIX Remove ambiguity for polymorphic queries #11195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 9, 2024
emteknetnz
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT
Because this PR targets
5.2which is currently in a change freeze, @maxime-rainville needs to approve it before it can be merged.I am targetting
5.2because it is the first minor release which includes multi-relational has_many relations, which is what has surfaced this as a problem (more details in the issue).Description
polymorphic has_many relations create a query that is too ambiguous - depending on what you join into the query, the {relation}Class and {relation}Relation columns might be on multiple tables.
This PR specifies the table that should be used.
Manual testing steps
See reproduction steps in the issue
Issues