BUG: Added setExcludedID() to exclude a certain record from uniqueness checking.

[svandragt]

As per issue #1399.

This pull request allows end-users to edit records that contain AjaxUniqueTextFields. Prior to this validation always fails when saving and updated record when AjaxUniqueTextFields are not updated. This is because the validation find the current record in the database.

With the patch, developers can use the new $ajaxutf->setExcludedID($this->ID) to exclude the current record from the uniqueness check.

[svandragt]

Travis build failure due to github unavailability, not code.

[chillu]

phpdoc should be placed before function declaration

[chillu]

Actually, can we change this to use DataList instead of restrictedTable etc? Then you can set the list, with your own exclusions applied (via DataList->exclude())

[chillu]

So there should be a setList() and getList() functionality. getList() would default to new DataList($this->restrictedTable), and it should throw a deprecation notice if the constructor arg is used. $restrictedField still makes sense, since we can't encapsulate this info in the DataList

[svandragt]

OK so this is the new implementation using DataList.
Working example: http://sspaste.com/paste/show/5165743a4851b

Because the ajaxUTF has to add filters / excludes for the current form's submitted values but before validating, I implemented setting a callback (setListProvider) which gets called at the start of the validate() method.

The change to the __constructor is simply that $restrictedField and $restrictedTable are now optional.

Two things:

1. I'm not sure where the validateURL ever gets used. It gets called in the Field() method but not used as far as I can see.
2. I've set the Deprecation notice to 3.2, not sure if this is correct.

[ajshort]

Why not just let setList accept a callback?

[ajshort]

Should accept any SS_List, not just data lists. Also, the API docs aren't very clear - the description isn't great, and the example isn't really necessary.

[chillu]

Also, please squash this to a single commit and remove the merge commits (with git rebase -i)

[chillu]

$maxLength definitely doesn't need to be a new required arg. It shouldn't be a constructor arg at all, we're trying to reduce those rather than add new ones. Can be a standard accessor.

EDIT: OK, this is the parent call ... and TextField has this argument as well (for legacy reasons). Good change.

[chillu]

Hello Sander, can you please fix the conventions and Andrew's comments on SS_List usage so we can merge?

[wilr]

@chillu didn't we delete this class from master? Any use changing it if it's deprecated.

[chillu]

Yeah we have removed it from master in #1974. This pull request and discussion is "older", and targets 3.1. I'm not too fussed with merging it for the sake of making the field slightly less useless in 3.1, but you're right we shouldn't spend much energy on the pull request. Sander, maybe you want to take on this field as your own module?

[simonwelsh]

Issues haven't been addressed in almost a year. Closing.