Fix some memory leaks in 3.1.0 admin #2340
Conversation
We werent calling tinyMCE.Editor.destroy, which is needed to clean up event bindings. The advanced theme also wasnt cleaning up after itself on destroy properly
| @@ -753,8 +753,11 @@ Sizzle is good for finding elements for a selector, but not so good for telling | |||
| * Add focusin and focusout support to bind and live for browers other than IE. Designed to be usable in a delegated fashion (like $.live) | |||
| * Copyright (c) 2007 Jörn Zaefferer | |||
| */ | |||
| $.support.focusInOut = !!($.browser.msie); | |||
| if (!$.support.focusInOut) { | |||
| if ($.support.focusinBubbles === undefined) { | |||
There was a problem hiding this comment.
Isn't typeof $.support.focusinBubbles === 'undefined' safer?
There was a problem hiding this comment.
I use undefined by itself a lot in Entwine. Strictly typeof X === 'undefined' is safer, but lots of things are going to break if you define undefined, not just this line :P
|
It still leaks 1MB in Chrome and 5MB in IE8 for me when simply switching back and forth between two page edit views in the standard install. But then again, a single reference is enough to cause this behaviour, and Hamish's work clearly fixes some leaks which should make further debugging work easier. Behat tests pass against this branch (no JS errors, on Firefox), I've done a bit of manual testing in IE8, happy to merge. |
Fix some memory leaks in 3.1.0 admin
|
Nice, thanks. |
No description provided.