FIX webfonts in preview iframe breaking admin fonts #2351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -225,14 +225,30 @@ | |||
| }, | |||
|
|
|||
| /** | |||
| * Return a style element we can use in IE8 to fix fonts (see readystatechange binding in onadd below) | |||
| */ | |||
| getFontFixStyleElement: function() { | |||
There was a problem hiding this comment.
Minor niggle: A method named like a getter shouldn't modify state (like adding DOM elements). How about appendFontFixStyleElement()?
There was a problem hiding this comment.
That's not quite accurate either, because it will only append if one doesn't already exist. I'll call it getOrAppendFontFixStyleElement
|
@hafriedlander would it be possible to add the URL of the source where the fix is coming from to the commit description? It looks truly peculiar, and having some extra information on it would be great. Unless it's long lost :-) |
In IE8, when a page in the preview iframe uses a web font (not just references it in CSS, but actually has glyphs present in the page), the fonts in the containing admin interface will become corrupted (display as all squares) until the mouse moves. This commit uses the technique described at http://stackoverflow.com/questions/9809351/ie8-css-font-face-fonts-only-working-for-before-content-on-over-and-sometimes#10557782 to cause the admin panel to re-calculated all it's fonts after the preview iframe has loaded, fixing the glitch
mateusz
added a commit
that referenced
this pull request
Aug 26, 2013
FIX webfonts in preview iframe breaking admin fonts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.