AjaxUniqueTextField is flagging a unique value when editing. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt ID is at position 5, for calling the AjaxUniqueTextField(), at position 5 aff $this->ID, so it's properly escaped in the validator.
|
Sorry, I don't understand what you're trying to do here. Could you add some inline documentation to the PHP file please? |
|
Valid point on the construct. I've been using this for a while now, but I could find a better method preferably indeed. |
|
I'll have a look on a better method later. Right now, I got a projectmanager breathing down my neck. |
|
Closing, doesn't merge cleanly and patch needs work. Looks like the field hasn't been updated to 3.0 yet but neither is it deprecated. |
bergice
pushed a commit
to open-sausages/silverstripe-framework
that referenced
this pull request
Nov 18, 2018
…eadcrumb_position Make breadcrumbs and toolbar title position consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the currennt (Unique) value being flagged as false. The current ID is at position 5, for calling the AjaxUniqueTextField(), at position 5 aff $this->ID, so it's properly escaped in the validator.
A problem mentioned a few times in IRC as wel.