Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default encoding for compass #2620

Merged
merged 1 commit into from Oct 30, 2013
Merged

Conversation

kinglozzer
Copy link
Member

See haml/haml#269 for a bit more info. Seems that OS X Mavericks causes this to occur, even when system default is set to utf-8.

@kinglozzer
Copy link
Member Author

Sorry, should probably have raised this against master

@chillu
Copy link
Member

chillu commented Oct 29, 2013

Do we have non-ascii characters in our core SCSS? What's the error you're getting? Not on Mavericks yet so can't verify.

@kinglozzer
Copy link
Member Author

Compass Error:�[31m�[0mSass::SyntaxError on line ["562"] of ../framework/scss/GridField.scss: Invalid US-ASCII character "\xE2"Run with --trace to see the full backtrace:

https://github.com/silverstripe/silverstripe-framework/blob/3.1/scss/GridField.scss#L562

It's the quote mark it doesn't like. Replacing it does fix it - it appears there are no other non-ascii characters, would that be a preferred fix?

@chillu
Copy link
Member

chillu commented Oct 30, 2013

Ah OK so this is a Ruby 2.0 (default on Mavericks) issue rather than OSX or Compass itself, right? Meh, if its that fragile then removing the quote will just invite the same error again down the line. But can you please add the same fix to framework/admin/config.rb and cms/config.rb, and check those still compile? @wilr OK with that?

See haml/haml#269. Seems that OS X Mavericks causes this to occur, even when system default is set to utf-8.

Force encoding in admin scss as well
@kinglozzer
Copy link
Member Author

I believe so, see what @wilr linked here silverstripe/silverstripe-cms#888:

Compass/compass#377.

Added to both, they still compile fine. Though I always get minor differences with the compiled CSS vs what's currently committed (such as whitespace, rule orders, different hex codes for gradient colour stops etc) - I wonder if that's because I'm using a more recent version of compass than when they were committed and the lighten()/darken() functions etc have been updated.

chillu added a commit that referenced this pull request Oct 30, 2013
Set default encoding for compass
@chillu chillu merged commit d445c7e into silverstripe:3.1 Oct 30, 2013
@chillu
Copy link
Member

chillu commented Oct 30, 2013

Thanks Mr. Loz :)

@kinglozzer kinglozzer deleted the patch-2 branch October 30, 2013 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants