Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG Make UI widget destroys more consistent to avoid exceptions. #3286

Merged
merged 1 commit into from
Jul 17, 2014

Commits on Jul 17, 2014

  1. BUG Fix several issues around onmatch/onunmatch entwines.

    1. Add missing _super calls.
    
    2. Make UI widget destroys more consistent to avoid exceptions.
    Selectable would throw an exception in the GridField.js if destroy
    called from onunmatch - at that stage jQuery UI would have had called
    the destroy already. Add a guard, and change to onremove, which triggers
    before the element is removed from DOM.
    
    3. DOM traversal fails after the element is removed from DOM.
    Onunmatch triggers after the removal of the element from the DOM, which
    makes DOM traversal fail. Use onremove instead, which triggers while the
    element is still in DOM.
    mateusz committed Jul 17, 2014
    Configuration menu
    Copy the full SHA
    b34aaca View commit details
    Browse the repository at this point in the history