Uploadfield doesn't save into inherited Image Classes #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if ($this->relationAutoSetting) { | ||
| // Search for classes that can hold the uploaded files by reflecting on the relations. Has one has priority. | ||
| $foundClasses = array_filter(array($record->has_one($name), $record->has_many($name), $record->many_many($name))); |
There was a problem hiding this comment.
Getting the object on the relationship should probably be done somewhere else, like in DataObject, rather than UploadField doing the discovery itself.
I can't recall if we already have something that does this or not. @sminnee?
|
Yeah, now that I look at it, maybe better to call $record->$name, and then try to get the relationship class from there. Will look into it tomorrow. |
DataObject::get_one returns false if not found, so better check for object. Also, the directory would not be cleaned, so on the subsequent run the files could end up having suffixes. missed this one
UploadField was relying entirely on the File::get_class_for_file_extension to select a class, so it could only create File or Image objects. This would break the relationships based on derived objects. Also make it respect the FileField::relationAutoSetting.
|
Fixed for many-many relationships: now will just traverse the relationship and make out the class from the received object. |
halkyon
pushed a commit
that referenced
this pull request
Apr 19, 2012
Uploadfield doesn't save into inherited Image Classes
sabina-talipova
pushed a commit
to creative-commoners/silverstripe-framework
that referenced
this pull request
Oct 18, 2022
…te-supermax-filesize ADD Upload_Validator::getLargestAllowedMaxFileSize method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: http://open.silverstripe.org/ticket/7140
Fixes the original issue, plus adds support to relationAutoSetting, adds comments, removes one unnecessary write.