Updated contrib docs, mention "DO NOT MERGE" pull requests #3428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Describe specifics on how to test the effects of the patch | ||
| * It's better to submit multiple patches with separate bits of functionality than a big patch containing lots of | ||
| changes | ||
| * Only submit a pull request for work you expect to be ready to merge. Work in progress is best discussed in a ticket, or on your own repository fork. |
There was a problem hiding this comment.
"in an issue" would be more accurate.
These should be avoided because they undermine the process of peer review and merging in github, we should strive to have zero open pull requests, as opposed to treating it as a stage for work in progress. Intermediary code review can happen in github forks instead. Also remove some checklist items which were based on the Trac bugtracker, e.g. its not longer possible to assign yourself to issues because of github's limited permission abilities.
chillu
force-pushed
the
pulls/contrib-docs
branch
from
0b7533a
to
5c9e88b
Compare
halkyon
added a commit
that referenced
this pull request
Aug 24, 2014
Updated contrib docs, mention "DO NOT MERGE" pull requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These should be avoided because they undermine the process of peer review and
merging in github, we should strive to have zero open pull requests, as
opposed to treating it as a stage for work in progress. Intermediary code
review can happen in github forks instead.
Also remove some checklist items which were based on the Trac bugtracker, e.g.
its not longer possible to assign yourself to issues because of github's
limited permission abilities.