Fix for Versioned->allVersions to work with new ORM #3497
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The context for this is that I wanted to show a history of changes for a "Product" page type.
The joined data was either missing, or was incorrect because it came from the wrong records.
I checked out the SQL, and found joins were using
Table_versiones.ID
field, rather thanTable_versions.RecordID
ANDTable_versions.Version
.Turned out it was using the joins generated by the ORM, rather than replacing with LEFT JOINS. The reason being that the query $tableJoin data is now stored as an array, rather than a string.
This has probably gone unnoticed in the CMS because the data that is retrieved in the page history isn't joined data.
Yes, needs unit tests! Just getting the problem out there for now.