Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Versioned->allVersions to work with new ORM #3497

Closed
wants to merge 1 commit into from

Conversation

jedateach
Copy link
Contributor

The context for this is that I wanted to show a history of changes for a "Product" page type.
The joined data was either missing, or was incorrect because it came from the wrong records.

I checked out the SQL, and found joins were using Table_versiones.ID field, rather than Table_versions.RecordID AND Table_versions.Version.

Turned out it was using the joins generated by the ORM, rather than replacing with LEFT JOINS. The reason being that the query $tableJoin data is now stored as an array, rather than a string.

This has probably gone unnoticed in the CMS because the data that is retrieved in the page history isn't joined data.

Yes, needs unit tests! Just getting the problem out there for now.

@halkyon
Copy link
Contributor

halkyon commented Sep 25, 2014

@jedateach Thanks! Change looks good, thought it needs some unit tests before we can accept it. :)

@jedateach jedateach closed this Mar 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants