Improve .htaccess commenting #3643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Done alongside improvements of the execution-pipeline.md docs. Installer comment taken from d5723f7.
tractorcow
pushed a commit
that referenced
this pull request
Nov 18, 2014
Improve .htaccess commenting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done alongside improvements of the execution-pipeline.md docs.
See silverstripe/silverstripe-installer#73 for installer commit.
I've noticed the generated .htaccess file here doesn't have the last bit
in the default .htaccess file:
It originated from @hafriedlander in 2011 (d5723f7), I'm not quite sure what it's trying to achieve.
Hamish, could you clarify?
/cc @wilr