Implemented naturalPrev function in Hierarchy class #3789
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| // if this is not an instance of the root class or has the root id, search the parent | ||
| if(!(is_numeric($root) && $root == $this->owner->ID || $root == $this->owner->class) |
There was a problem hiding this comment.
You need some more brackets here to group the conditions.
There was a problem hiding this comment.
Is this enough?
// if this is not an instance of the root class or has the root id, search the parent
if($root != $this->owner->ID && $root != $this->owner->class && ($parent = $this->owner->Parent())) {
// ....
}
|
I think this needs to go against 3 branch |
|
This also needs tests |
|
This actually needs to go against master as it's a breaking API change... even though it was never implemented :( |
| if(!(is_numeric($root) && $root == $this->owner->ID || $root == $this->owner->class) | ||
| && ($parent = $this->owner->Parent())) { | ||
|
|
||
| return $parent->naturalPrev( $className, $root, $this->owner ); |
There was a problem hiding this comment.
spacing inside parenthesis shouldn't be there
|
@tractorcow is there any value in someone picking this up? I don't even know why there's a function stub for this |
|
We should just remove the stub in 4.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been marked as "todo" since forever. I just need it for a project.
naturalNextfunction doesn't have unit tests, so they both need unit tests at some stage.Only tested with parent->children relationship so far, rather than deep nesting.