BUGFIX: 7117 Fixes #386
Merged
BUGFIX: 7117 Fixes #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes: * Changes to chosen to include a custom function that will let the drop-down rise-up if there is room and it would otherwise drop beneath the size of the window (changes in coffeescript, jquery output, and chosen css) * Changes in SCSS to stop the automatic addition of scrollbars, and to limit the extra space at the bottom of the filter div Issues remaining: * jLayout is calculating the height of the filter div incorrectly. It is assuming the div is around 70px longer than it is. This height assumption is linked somehow to chosen, as initiating the select box results in a correct height calculation.
chillu
added a commit
that referenced
this pull request
May 7, 2012
--- Includes: * Changes to chosen to include a custom function that will let the drop-down rise-up if there is room and it would otherwise drop beneath the size of the window (changes in coffeescript, jquery output, and chosen css) * Changes in SCSS to stop the automatic addition of scrollbars, and to limit the extra space at the bottom of the filter div Issues remaining: * jLayout is calculating the height of the filter div incorrectly. It is assuming the div is around 70px longer than it is. This height assumption is linked somehow to chosen, as initiating the select box results in a correct height calculation.
|
Thanks Naomi, works like a charm :) |
| @@ -611,6 +611,10 @@ body.cms { | |||
| @include box-shadow($color-shadow-dark 0 0 ($grid-x / 2)); | |||
| float: left; | |||
| position: relative; | |||
|
|
|||
| &.filter{ | |||
| padding:0 !important; | |||
There was a problem hiding this comment.
Every time someone uses !important, a kitten dies.
There was a problem hiding this comment.
That's a lot of dead kittens! But I agree in principal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes:
Issues remaining: