Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstracting GridField row class generation #4083

Merged
merged 1 commit into from Apr 20, 2015
Merged

Abstracting GridField row class generation #4083

merged 1 commit into from Apr 20, 2015

Conversation

assertchris
Copy link
Contributor

This further abstracts the classes generated for each row of the GridField. Without it, subclasses need to implement the same first/last/odd/even/base classes, and they also become responsible for the special data-* parameters GridField needs.

@willmorgan
Copy link
Contributor

Hmm, this is now a stealthy API change because of #4079 😉

I think we need to be more careful in the future - we've introduced 2 new methods and then changed their argument signature fairly quickly, and taken them in to 3.1.

Does it matter so much that they're new and protected?

@tractorcow, thoughts?

@assertchris
Copy link
Contributor Author

@willmorgan "Does it matter so much that they're new and protected?" and there has been no framework release featuring the changes... :)

@tractorcow
Copy link
Contributor

I agree with @willmorgan in that I think it's more a sign we should PR minor changes more carefully, to prevent us having to patch them up like this in the future. ;D I'm as guilty of that as any.

We can probably excuse this one as a replacement PR for the prior.

tractorcow pushed a commit that referenced this pull request Apr 20, 2015
…s-generation

Abstracting GridField row class generation
@tractorcow tractorcow merged commit f2e2d4e into silverstripe:3.1 Apr 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants