Clean up NullableField #4114
Merged
Clean up NullableField #4114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @return NullableField | ||
| * | ||
| * @param FormField $valueField | ||
| * @param null $isNullLabel |
There was a problem hiding this comment.
boolean instead of null?
|
@tractorcow ping |
| if ( is_null($this->isNullLabel) ) { | ||
| // Set a default label if one is not provided. | ||
|
|
||
| if($isNullLabel) { |
There was a problem hiding this comment.
We need to support false for explicitly empty labels. Can we change this to if(isset($isNullLabel)) to keep the current behaviour?
|
Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.